benchmark: add benchmark utility for isNativeError function #61180
+39
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
benchmark
RafaelGSS
reviewed
Dec 27, 2025
Member
RafaelGSS
left a comment
RafaelGSS
left a comment
There was a problem hiding this comment.
I'm not confident about how useful this benchmark is
benchmark/util/is-native-error.js
Outdated
|
|
||
| bench.start(); | ||
| for (let iteration = 0; iteration < n; iteration++) { | ||
| func(arg); |
Member
There was a problem hiding this comment.
This is likely being optimized.
Member
Author
There was a problem hiding this comment.
Hi, I tried to fix this by using more arguments and variable arguments. 5fcf423
anonrig
approved these changes
Dec 27, 2025
Member
Any recommendations? |
lpinca
reviewed
Dec 27, 2025
|
|
||
| const func = { native: util, js: types }[version].isNativeError; | ||
|
|
||
| const testArgs = [args[argument], args[argument], args[argument]]; |
Member
There was a problem hiding this comment.
Any reason for this? If I'm reading correctly, the elements are all equals.
Member
Author
There was a problem hiding this comment.
I wanted to provide more arguments.
Member
There was a problem hiding this comment.
With
const testArg = testArgs[iteration % 3];
func(testArg)below, I'm still not sure I understand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added benchmark code for isNativeError function
for: #60468 (comment)